Capped/Static Weapon Glow Bug in DX9

[JamePOWER1]

Hey everyone,

After many hours of deep diving into the source code and debugging the DX9 engine, I finally managed to fix the capped and static weapon glow bug!
I’ve seen a few possible solutions posted around the forum before, but none of them actually tackled the root cause. The real reason the glow gets capped or stuck in certain scenarios is due to several specific flaws in the engine's update and rendering logic that I managed to map out.

Since this took a lot of focused work to figure out, I want to share the step-by-step fix with those who are actively trying to solve it.

If you are still struggling with this bug and want my help:

React to this post.

&

Comment below explaining what you have already tried to fix it.

Once you do that, I'll reach out via DM and share my exact solution with you. Happy coding!

 

[mudoek]

share fix please

 

[ShadowJr]

I have a similar issue, but I don’t know if it’s related. I haven’t looked into finding the cause yet.

 

[grimjr90]

View attachment 726

I have a similar issue, but I don’t know if it’s related. I haven’t looked into finding the cause yet.

Exact same issue, I've tried replacing several .cpp with another and still no luck. If you can share your fix with the community we would be grateful.

 

[zLuke]

There is a small chance that if you describe the problem, they will give you a solution. I'm not interested in guessing based on screenshots. What's on it? What is the problem?

 

[JamePOWER1]

So guys, I genuinely intended to share this with the people in this thread, especially those I saw who were already looking for a solution to this. Because, believe it or not, it's not easy at all to fix it in a way that doesn't break the rest of the source code.

Unfortunately, I've noticed some of my improvements from this forum being used on more than one private server that makes money from its users. Let me be clear that this isn't a problem at all; after all, if I'm sharing it, it's exactly so people can use it. But in some of these cases, my posts didn't get a single 'thank you' here on the forum, let alone a like, which in my view is the bare minimum if what I shared helped you out.

So no, I take back what I said about sharing the glow solution via private message with those looking for it. From now on, whatever I actually share here will go through a very strict filter. I don't want my work used by for-profit services without even getting a mention, no matter how small my contribution was. Sorry, but you'll have to rack your brains and grab a pen and paper just like I did to come up with an acceptable solution.

 

[ximboliex]

So guys, I genuinely intended to share this with the people in this thread, especially those I saw who were already looking for a solution to this. Because, believe it or not, it's not easy at all to fix it in a way that doesn't break the rest of the source code.

Unfortunately, I've noticed some of my improvements from this forum being used on more than one private server that makes money from its users. Let me be clear that this isn't a problem at all; after all, if I'm sharing it, it's exactly so people can use it. But in some of these cases, my posts didn't get a single 'thank you' here on the forum, let alone a like, which in my view is the bare minimum if what I shared helped you out.

So no, I take back what I said about sharing the glow solution via private message with those looking for it. From now on, whatever I actually share here will go through a very strict filter. I don't want my work used by for-profit services without even getting a mention, no matter how small my contribution was. Sorry, but you'll have to rack your brains and grab a pen and paper just like I did to come up with an acceptable solution.

I understand what you're saying about the thanks, but when you get to a certain age, that doesn't matter so much. What matters is the contribution you make to a community that used to be very diverse, but now, because of DDoS attacks, nothing is the same. But I do contribute, and I'll continue to do so. Any idea that comes to me, I'll post on the forum because it's time to bring everything back to "TOP." I'm going to try to bring a new mod or fix to the forum every weekend; it's fun. Ahhhh, what memories, ServerDev!

 

[Mothanna]

So guys, I genuinely intended to share this with the people in this thread, especially those I saw who were already looking for a solution to this. Because, believe it or not, it's not easy at all to fix it in a way that doesn't break the rest of the source code.

Unfortunately, I've noticed some of my improvements from this forum being used on more than one private server that makes money from its users. Let me be clear that this isn't a problem at all; after all, if I'm sharing it, it's exactly so people can use it. But in some of these cases, my posts didn't get a single 'thank you' here on the forum, let alone a like, which in my view is the bare minimum if what I shared helped you out.

So no, I take back what I said about sharing the glow solution via private message with those looking for it. From now on, whatever I actually share here will go through a very strict filter. I don't want my work used by for-profit services without even getting a mention, no matter how small my contribution was. Sorry, but you'll have to rack your brains and grab a pen and paper just like I did to come up with an acceptable solution.

welcome to top community , if you're so worried about it even if u sell x mods, fixes it will be more profits for them resell it after removing any credit u try to put , that's one of reasons we stopped provided random people anything
and this bug not a big deal either its annoying to figure out but simple way to use organized filters of shaders for x effect and glows ,
the issue fully in how some glows need x shaders and x type of technique's from eff.fx which is type 3 works for every glows with zero issues
but u can't set every effect to that, that's why simple way let only weapons glows to using it

even effect stucks pure fps issues, people using ai and see visual effects and be oh ye that's great, but doesn't know each touch with ai = more bugs

 

[mudoek]

at the end we can deal with this bug by using custom itemrefineeffectinfo and ItemRefineInfo, works nice. if you dont know how to fix, use this way

 

[grimjr90]

There is a small chance that if you describe the problem, they will give you a solution. I'm not interested in guessing based on screenshots. What's on it? What is the problem?

basically upon logging/teleporting/etc some effects such as "Intense Magic" buff does freeze in place or even disappear.

So guys, I genuinely intended to share this with the people in this thread, especially those I saw who were already looking for a solution to this. Because, believe it or not, it's not easy at all to fix it in a way that doesn't break the rest of the source code.

Unfortunately, I've noticed some of my improvements from this forum being used on more than one private server that makes money from its users. Let me be clear that this isn't a problem at all; after all, if I'm sharing it, it's exactly so people can use it. But in some of these cases, my posts didn't get a single 'thank you' here on the forum, let alone a like, which in my view is the bare minimum if what I shared helped you out.

So no, I take back what I said about sharing the glow solution via private message with those looking for it. From now on, whatever I actually share here will go through a very strict filter. I don't want my work used by for-profit services without even getting a mention, no matter how small my contribution was. Sorry, but you'll have to rack your brains and grab a pen and paper just like I did to come up with an acceptable solution.

understood and thats fair to your end, but as ximboliex mentioned we do have this community in order to keep TOP alive by supporting one another and I do feel you, I used to share a lot of stuff lua based back then but eventually got tired and focused purely now on my real life and build a server if I am free.

 

[Panda]

I think they are talking about these effects.

I haven't mapped this out entirely yet. Glows are not obvious and testing takes forever

 

[JamePOWER1]

Hey everyone, it’s been a crazy, hectic week for me. As soon as things settle down, I’ll properly get back to everyone who reached out. Especially those I respect in this community. so I just ask for a little patience.

 

[JamePOWER1]

Also i’m still tinkering with things.. Specifically what I believe to be the last issue I caused, which involves the skills. But I’ve already mapped out and fixed the vast majority of them; once I sort this out, I’ll reply to the DMs.

 

[grimjr90]

Any updates to this topic so far?

 

[zLuke]

Before


After


1. Opening it \sources\Engine\src\MPModelEff.cpp ~ str 615
2. Find function void CMPModelEff::RenderVS()
3. In this function we find the line if(m_pCEffect->IsChangeably()) ~str 741

4. We replace this string and the rest of the function. That is, up to the string void CMPModelEff::RenderSoft()

if(m_pCEffect->IsChangeably())
        {
#ifdef USE_MGR
            m_pCEffect->Begin();
#endif
            m_pCEffectFile->SetTechnique(3);
            m_pCEffectFile->Begin(D3DXFX_DONOTSAVESTATE);
            m_pCEffectFile->Pass(0);
            m_pCEffect->m_pDev->SetSamplerStateForced(0, D3DSAMP_MINFILTER, D3DTEXF_LINEAR);
            m_pCEffect->m_pDev->SetSamplerStateForced(0, D3DSAMP_MAGFILTER, D3DTEXF_LINEAR);
            if(!m_pCEffect->IsAlpah())
            {
                m_pCEffect->m_pDev->SetRenderStateForced(D3DRS_ALPHABLENDENABLE, FALSE);
                m_pCEffect->m_pDev->SetRenderStateForced(D3DRS_ZWRITEENABLE, TRUE);
            }
            else
            {
                m_pCEffect->m_pDev->SetRenderStateForced(D3DRS_ZWRITEENABLE, FALSE);
                m_pCEffect->m_pDev->SetRenderStateForced(D3DRS_ALPHABLENDENABLE, TRUE);
            }
            m_pCEffect->m_pDev->SetVertexShader(NULL);
            m_pCEffect->m_pDev->SetFVF(EFFECT_VER_FVF);
            m_pCEffect->SetTexture();

            if(m_bBindbone)
            {
                D3DXMatrixMultiply(&m_pCurCortrol->m_SMatResult, &m_SMatResult, &m_SpmatBone);
#ifdef USE_RENDER
                m_pCEffect->m_pDev->SetTransformWorld( &m_pCurCortrol->m_SMatResult);
#else
                m_pCEffect->m_pDev->SetTransform(D3DTS_WORLDMATRIX(0), &m_pCurCortrol->m_SMatResult);
#endif
            }
            else
            {
#ifdef USE_RENDER
                m_pCEffect->m_pDev->SetTransformWorld( &m_SMatResult);
#else
                m_pCEffect->m_pDev->SetTransform(D3DTS_WORLDMATRIX(0), &m_SMatResult);
#endif
            }
            m_pCEffect->m_pDev->SetRenderState(D3DRS_TEXTUREFACTOR, m_pCurCortrol->m_dwCurColor);
            m_pCEffect->m_pDev->SetTextureStageStateForced(0, D3DTSS_COLORARG2, D3DTA_TFACTOR);
            m_pCEffect->m_pDev->SetTextureStageStateForced(0, D3DTSS_ALPHAARG2, D3DTA_TFACTOR);

            m_pCEffect->Render();
#ifdef USE_MGR
            m_pCEffect->End();
#endif
            m_pCEffectFile->End();
            m_pCEffect->m_pDev->SetRenderState(D3DRS_TEXTUREFACTOR, D3DXCOLOR(1.0f, 1.0f, 1.0f, 1.0f));
            m_pCEffect->m_pDev->SetTextureStageStateForced(0, D3DTSS_COLORARG2, D3DTA_TEXTURE);
            m_pCEffect->m_pDev->SetTextureStageStateForced(0, D3DTSS_ALPHAARG2, D3DTA_DIFFUSE);
            continue;
        }
#ifdef USE_MGR
        m_pCEffect->Begin();
#endif
        m_pCEffectFile->SetTechnique(m_iIdxTech);
        m_pCEffectFile->Begin(D3DXFX_DONOTSAVESTATE);
        m_pCEffectFile->Pass(0);
        if(!m_pCEffect->IsAlpah())
        {
            m_pCEffect->m_pDev->SetRenderStateForced(D3DRS_ALPHABLENDENABLE, FALSE);
            m_pCEffect->m_pDev->SetRenderStateForced(D3DRS_ZWRITEENABLE, TRUE);
        }
        else
        {
            m_pCEffect->m_pDev->SetRenderStateForced(D3DRS_ZWRITEENABLE, FALSE);
            m_pCEffect->m_pDev->SetRenderStateForced(D3DRS_ALPHABLENDENABLE, TRUE);
        }
        m_pCEffect->m_pDev->SetVertexShader(NULL);
        m_pCEffect->m_pDev->SetFVF(EFFECT_VER_FVF);
        m_pCEffect->SetTexture();

        if(m_pCEffect->IsBillBoard())
        {
            if(!m_bUseZ)
                m_pCEffect->m_pDev->SetRenderState(D3DRS_ZENABLE, FALSE);
            D3DXVECTOR3 vtpos(&m_SMatResult._41);
            if(!m_pCEffect->IsRotaBoard())
                D3DXMatrixIdentity(&m_SMatResult);
            D3DXMatrixMultiply(&m_SMatResult,&m_SMatResult,m_pCEffect->getBillBoardMatrix());

            if(m_bBindbone)
            {
                m_SMatResult._41 = m_SpmatBone._41;
                m_SMatResult._42 = m_SpmatBone._42;
                m_SMatResult._43 = m_SpmatBone._43;

            }
            else
            {
                m_SMatResult._41 = vtpos.x;
                m_SMatResult._42 = vtpos.y;
                m_SMatResult._43 = vtpos.z;
            }

        }else
        {
            if(m_bBindbone)
                D3DXMatrixMultiply(&m_SMatResult, &m_SMatResult, &m_SpmatBone);
        }

        if(m_pCEffect->getType() != EFFECT_MODEL)
        {
            if(m_pCEffect->getType() == EFFECT_MODELUV)
            {
                m_pCurCortrol->FillModelUVSoft(m_pCEffect->m_pCModel);
            }
            else
            {
                m_pCurCortrol->FillTextureUVSoft(m_pCEffect->m_pCModel);
            }
        }

        m_pCEffect->m_pDev->SetRenderState(D3DRS_TEXTUREFACTOR, m_pCurCortrol->m_dwCurColor);
        m_pCEffect->m_pDev->SetTextureStageStateForced(0, D3DTSS_COLORARG2, D3DTA_TFACTOR);
        m_pCEffect->m_pDev->SetTextureStageStateForced(0, D3DTSS_ALPHAARG2, D3DTA_TFACTOR);
#ifdef USE_RENDER
        m_pCEffect->m_pDev->SetTransformWorld(&m_SMatResult);
#else
        m_pCEffect->m_pDev->SetTransform(D3DTS_WORLDMATRIX(0), &m_SMatResult);
#endif

        m_pCEffect->Render();
#ifdef USE_MGR
        m_pCEffect->End();
#endif
        m_pCEffect->m_pDev->SetTextureStageStateForced(0, D3DTSS_COLORARG2, D3DTA_TEXTURE);
        m_pCEffect->m_pDev->SetTextureStageStateForced(0, D3DTSS_ALPHAARG2, D3DTA_DIFFUSE);
        m_pCEffectFile->End();
    }
}

5. We compile MindPower and enjoy it.

Reason.
On DX9 with a normal GPU, the effects are rendered through RenderVS instead of Soft. Tier glow is (cylinders/planes). It is rendered by DrawSubset/RenderTob through FVF + World + TFactor. In RenderVS, they were assigned a vertex shader and UV in the VS constants. Mesh ignores this, so the tier geometry was not rendered. The "snow" remained the same at all levels, so the glow "exists" but does not grow significantly.

 

[mudoek]

nice! but all other effects bugs. u.u but good to know the reason of the bug.